[3.4b] slice2java skips exception fields with // comments

joshmoore

Running slice2java against the following slice definition produces one exception (E1) with only a single field (concurrency) and one exception (E2) with three fields (concurrency, backOff, type)

module ex {
  exception E1 {
      bool    concurrency;
      long    backOff;    // Only used if ConcurrencyException
      string  type;       // Ice static type information
  };
  exception E2 {
      bool    concurrency;
      long    backOff;    /* Only used if ConcurrencyException */
      string  type;       /* Ice static type information */
  };
};

dwayne

On what platform are you seeing this? Did you compile MCPP yourself? If so, did you apply the patch we provided?

joshmoore

This was on Mac 10.4 with an up-to-date MacPorts installation. I compiled mcpp with:

test -e $MCPP_DONE || {
    patch -p0 < ../mcpp/patch.mcpp.2.7.2
    touch $MCPP_DONE
}
test -e $MCPP_HOME || {
    ./configure CFLAGS="-fno-common -fPIC" --enable-mcpplib --disable-shared --prefix=$MCPP_HOME
    make
    make install
}

and then called

export MCPP_HOME=$MCPP_HOME

before compiling Ice, but apparently the MacPorts mcpp 2.7.2 (installed as a dependency of ice-cpp 3.3.1) was still picked up before MCPP_HOME. Forcibly removing the MacPorts version fixed the problem.

Let me know if it's worth trying to reproduce the build error, but for now, it's working. Thanks for the help, Dwayne.

dwayne

The issue is expected if the mcpp patch is not applied.