Demos from the former book (now Wiki) use virtual inheritance for no reason

grembogrembo Member Michael GmelinOrganization: Grem Equity GmbHProject: E-Commerce platform
Hi,

A co-worker noticed that we use virtual public inheritance from Ice::Application in our non-IceBox applications. I checked your documentation and noticed that the examples from the former book (now part of the wiki) all use virtual public inheritance from Ice::Application like in:
class FilesystemApp : virtual public Ice::Application
{
...
};

You can find those in the source tree
grep -R virtual * | grep Ice::Application
cpp/demo/book/simple_filesystem/Server.cpp:class FilesystemApp : virtual public Ice::Application
cpp/demo/book/map_filesystem/Server.cpp:class FilesystemApp : public virtual Ice::Application
cpp/demo/book/lifecycle/Server.cpp:class FilesystemApp : virtual public Ice::Application
cpp/demo/book/evictor_filesystem/Server.cpp:class FilesystemApp : virtual public Ice::Application

as well as in the Wiki, e.g.:

Example of a File System Server in C++ - Ice 3.5 - ZeroC

Since there is no reason to use virtual here I'd suggest to update the documentation.

Cheers,
Michael

Comments

  • benoitbenoit Rennes, FranceAdministrators, ZeroC Staff Benoit FoucherOrganization: ZeroC, Inc.Project: Ice ZeroC Staff
    Hi,

    Thanks, we will fix this.

    Cheers,
    Benoit.
Sign In or Register to comment.